Bug 14887 - xorg/driver/xf86-video-nsc - libpciaccess conversion
Summary: xorg/driver/xf86-video-nsc - libpciaccess conversion
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/nsc (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2008-03-07 12:25 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-28 15:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-Ensure-the-driver-will-not-compile.patch (1.40 KB, patch)
2008-03-07 12:25 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-Convert-nsc-driver-for-libpciaccess.patch (7.28 KB, patch)
2008-07-22 13:12 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-07 12:25:06 UTC
Created attachment 14928 [details] [review]

on an environment where only libpciaccess is available.

  It was compiling without prototype for xf86GetPciVideoInfo, and driver
loaded with it as an unresolved symbol.

  Other remaining compile warnings are due to REGION_INIT macro receiving
a pointer to variable on the stack, and the NULL check generating a warning
about the address of the variable always evaluating to true.
Comment 1 Paulo César Pereira de Andrade 2008-07-22 12:42:09 UTC
  Previous patch was to cause an compilation failure.

  The new version attempts to make libpciaccess conversion,
following pattern used on other drivers.
  This driver probably is obsoleted by the geode driver,
but maybe it is still required for some old hardware not
supported by the geode neither amd driver.
Comment 2 Paulo César Pereira de Andrade 2008-07-22 13:12:35 UTC
Created attachment 17826 [details] [review]
Comment 3 Paulo César Pereira de Andrade 2008-07-28 15:18:24 UTC
Fixed in commit bfcfdff7a00a579362eca0def5b85c1a013ef1e0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.