Bug 14865 - xorg/driver/xf86-video-v4l - Compile warning fixes
Summary: xorg/driver/xf86-video-v4l - Compile warning fixes
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: janitor
Depends on:
Reported: 2008-03-06 13:40 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-21 14:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-Compile-warning-fixes.patch (1.01 KB, patch)
2008-03-06 13:40 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-06 13:40:01 UTC
Created attachment 14891 [details] [review]

Include unistd.h for "close" prototype.
Include sys/ioctl.h instead of asm/ioctl.h to also get "ioctl" prototype.

Only remaining warning is about REGION_INIT macro, as it commonly receives
the address of a variable in stack, thus generating a warning about address
of "<name>" will always evaluate as 'true'.
Comment 1 Paulo César Pereira de Andrade 2008-07-21 14:50:54 UTC
  Not a bug because patch would just allow compiling
without warnings, but no functionality change if
applying or not the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.