Bug 14839 - xorg/lib/libAppleWM - ansification
Summary: xorg/lib/libAppleWM - ansification
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-03-05 11:48 UTC by Paulo César Pereira de Andrade
Modified: 2009-01-30 10:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-Ansify-libAppleWM.patch (8.51 KB, patch)
2008-03-05 11:48 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-05 11:48:40 UTC
Created attachment 14868 [details] [review]
0001-Ansify-libAppleWM.patch

Special attention may be required here due to functions with arguments
of type short.
  proto/applewmproto/applewm.h already declares ansi prototypes with
short arguments, so, theoretically, this patch should be correct, but
there may exist problems (probably not, at least with gcc, as the
functions had a prototype).
Comment 1 Paulo César Pereira de Andrade 2009-01-30 10:58:03 UTC
  Already commited to git master.

  Problems would occur if a C file made calls without
including the proper header (as it would call with
int arguments), or if source with the function definitions
did not include the header with the function prototypes,
as it "should" generate a function that expected int
arguments, due to using K&R function definition.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.