Bug 14783 - xorg/driver/xf86-video-r128 - Avoid usage of LoaderSymbol
Summary: xorg/driver/xf86-video-r128 - Avoid usage of LoaderSymbol
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-03-02 09:56 UTC by Paulo César Pereira de Andrade
Modified: 2008-03-02 11:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-Avoid-usage-of-LoaderSymbol.patch (1.73 KB, patch)
2008-03-02 09:56 UTC, Paulo César Pereira de Andrade 		no flags Details | Splinter Review
View All

Description Paulo César Pereira de Andrade 2008-03-02 09:56:24 UTC 
Created attachment 14769 [details] [review]
0001-Avoid-usage-of-LoaderSymbol.patch

It can be dangerous. This patch is based on the previous one when r128
was in xf86-video-ati. The problem is that if gR128EntityIndex is not
explicitly marked as a public symbol, and weird things may happen when
compiling with hidden symbols.
Since the symbol is in the same shared binary of its callers, just use
it, instead of using LoaderSymbol. Could also just replace calls
getR128EntityIndex() to direct access to gR128EntityIndex.
Comment 1 Alex Deucher 2008-03-02 11:59:53 UTC 
applied:
a4fafa97b31bb7da01dd92236b42a418ca482992

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.