Bug 14771 - Rewrite commented out out code for audit message compression.
Summary: Rewrite commented out out code for audit message compression.
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on: 14730
Blocks: 964
  Show dependency treegraph
Reported: 2008-03-01 16:34 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-23 15:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

0007-Rewrite-commented-out-out-code-for-audit-message-com.patch (3.92 KB, patch)
2008-03-01 16:34 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-01 16:34:04 UTC
Created attachment 14752 [details] [review]

Just always print the "audit" message at the first request, and flush
the repeat counter message when a new message (with different data) arrives,
as well as when doing the "cleanup" by calling FreeAuditTimer().

  This should also fix bug #964, that I believe isn't really Xprint related.
I know 3 digit bugs are rare, sorry.
Comment 1 Paulo César Pereira de Andrade 2008-04-12 19:27:04 UTC
  The updated patch is in xorg-patches.tar.bz2,
attached to #14730, but the patch here should
still apply cleanly (as the version in #14730
was just a git-am of this one).
Comment 2 Paulo César Pereira de Andrade 2008-07-23 15:22:12 UTC
  This patch is duplicated in my tarball of
the X Server patches.

  Also this patch has been obsoleted by commit
6c27b911222cdee9a057de0be7e8b2eff8b1ff2a, but I
still believe this patch is better, as it doesn't
add a timer that waits to check if the message is
sent again, instead, it just uses a counter that
is reset when it is told to print a different
  I think there are other far more serious problems
if someone runs a X Server accepting TCP connections
from untrusted sources then a possible DOS (in the
case of my patch where it could be made in a way
where it would always send different messages, but
this will also affect the current patch...)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.