Bug 14742 - xorg/driver/xf86-video-savage - Don't call nonexisting functions and compile warning fixes
Summary: xorg/driver/xf86-video-savage - Don't call nonexisting functions and compile ...
Status: RESOLVED NOTABUG
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/savage (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-02-28 22:32 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-21 14:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-Replace-ALLOCATE_LOCAL-DEALLOCATE_LOCAL-with-xalloc.patch (2.33 KB, patch)
2008-02-28 22:32 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Remove-declaration-and-call-to-non-existing-function.patch (1.42 KB, patch)
2008-02-28 22:32 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0003-Compile-warning-fixes.patch (12.14 KB, patch)
2008-03-07 10:59 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-Remove-declaration-and-call-to-non-existing-function.patch (1.42 KB, patch)
2008-03-20 21:27 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Compile-warning-fixes.patch (12.95 KB, patch)
2008-03-20 21:28 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Compile-warning-fixes.patch (13.20 KB, patch)
2008-04-12 17:46 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-02-28 22:32:30 UTC
Created attachment 14702 [details] [review]
0001-Replace-ALLOCATE_LOCAL-DEALLOCATE_LOCAL-with-xalloc.patch

Just remade patches I posted some time ago at xorg@ mailing
list. Please consider applying.
Comment 1 Paulo César Pereira de Andrade 2008-02-28 22:32:54 UTC
Created attachment 14703 [details] [review]
0002-Remove-declaration-and-call-to-non-existing-function.patch
Comment 2 Paulo César Pereira de Andrade 2008-03-07 10:59:39 UTC
Created attachment 14919 [details] [review]
0003-Compile-warning-fixes.patch
Comment 3 Paulo César Pereira de Andrade 2008-03-07 11:03:08 UTC
Added compile warning fixes patch.
Patch 0001-Replace-ALLOCATE_LOCAL-DEALLOCATE_LOCAL-with-xalloc.patch
should be applied if compiling with git master or 1.5 branch, otherwise
the savage driver will fail due to unresolved symbols (i.e. ALLOCATE_LOCAL
was previously a macro to choose between alloca/xalloc, but now it is
compiled as a "missing" function call).
Comment 4 Paulo César Pereira de Andrade 2008-03-20 21:27:46 UTC
Created attachment 15359 [details] [review]
0001-Remove-declaration-and-call-to-non-existing-function.patch

  Regenerate patches agains't current git master.

Patch1 (Attachment 14702 [details]) was fixed in commit
6adc23cb19bfd331221df8dccb2dc88b8fc77821
Comment 5 Paulo César Pereira de Andrade 2008-03-20 21:28:35 UTC
Created attachment 15360 [details] [review]
0002-Compile-warning-fixes.patch

  Cast printf format arguments and remove unused variables.
  Remaining warnings are about unused variable pScreen, but it is an
argument to REGION macros, that may be defined as function calls instead of
"inlined", and then the argument would be used. And two other warnings due
to assigning pciaddr_t (an unsigned long long) to a pointer, that should
only generate a warning on 32 bit architecture.
Comment 6 Paulo César Pereira de Andrade 2008-04-12 17:46:54 UTC
Created attachment 15858 [details] [review]
0002-Compile-warning-fixes.patch

  Patch2 remade to match current sources.
  Patch1 should still apply cleanly.
Comment 7 Paulo César Pereira de Andrade 2008-05-21 13:20:57 UTC
Comment on attachment 15359 [details] [review]
0001-Remove-declaration-and-call-to-non-existing-function.patch

  Obsoleted by commit 09c4dcc658b07f2672388eb4ab5fee3ebe190fc9
Comment 8 Paulo César Pereira de Andrade 2008-07-21 14:33:06 UTC
  Only remaining problems are arguably the warnings
about void *.
  gcc should generate correct code to convert "%ld"
format with drm_handle_t argument, and mixed code
and declarations should not be a problem because
xorg compilation requires c99 features.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.