Bug 14741 - xorg/driver/xf86-video-mga - Replace ALLOCATE_LOCAL macros with xalloc and compile warning fixes
Summary: xorg/driver/xf86-video-mga - Replace ALLOCATE_LOCAL macros with xalloc and co...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/mga (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Tilman Sauerbeck
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-02-28 22:25 UTC by Paulo César Pereira de Andrade
Modified: 2008-03-16 01:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-Replace-ALLOCATE_LOCAL-DEALLOCATE_LOCAL-with-xalloc.patch (2.52 KB, patch)
2008-02-28 22:25 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Compile-warning-fixes.patch (5.75 KB, patch)
2008-03-07 14:12 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Compile-warning-fixes.patch (7.03 KB, patch)
2008-03-15 18:12 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-02-28 22:25:54 UTC
Created attachment 14701 [details] [review]
0001-Replace-ALLOCATE_LOCAL-DEALLOCATE_LOCAL-with-xalloc.patch

This is required, otherwise it will be compiled with ALLOCATE_LOCAL
at all as missing function calls.

   I posted this patch at xorg@ some time ago. Posting again
to avoid it being lost.
Comment 1 Paulo César Pereira de Andrade 2008-03-07 14:12:30 UTC
Created attachment 14940 [details] [review]
0002-Compile-warning-fixes.patch
Comment 2 Paulo César Pereira de Andrade 2008-03-07 14:14:18 UTC
  Added a patch for some compiler warning fixes.

  Only patch 0001 should really be applied as the macros ALLOCATE_LOCAL
and DEALLOCATE_LOCAL no longer exists, and are being compiled as
function calls in git master or X Server 1.5.
Comment 3 Paulo César Pereira de Andrade 2008-03-15 18:12:26 UTC
Created attachment 15164 [details] [review]
0002-Compile-warning-fixes.patch

  Remade patch 2 to avoid one warning about whitespace error
when git am'ing it.
  Also added some minor changes to not mix declarations and code.
Comment 4 Tilman Sauerbeck 2008-03-16 01:26:46 UTC
Applied patch 1 in 0c61ccde7857dc7514881636144f95df51edaddf.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.