Created attachment 14690 [details] [review] 0001-Don-t-call-xf86AddLocalDevice-and-xf86XInputSetSendC.patch I posted this patch at xorg@ some time ago. Posting again to avoid it being lost. Also a bit unsure about what would be the proper way to check for xf86_ansic functions, as adding a macro for checking the proper sdk header, and cut&pasting everywhere may not be the better way, so it checks XORG_VERSION_CURRENT, but that value has not yet been updated in git master...
Created attachment 14691 [details] [review] 0002-Don-t-call-xf86GetErrno-instead-use-errno-directly.patch
(In reply to comment #0) > Created an attachment (id=14690) [details] > 0001-Don-t-call-xf86AddLocalDevice-and-xf86XInputSetSendC.patch > > I posted this patch at xorg@ some time ago. Posting again > to avoid it being lost. > > Also a bit unsure about what would be the proper way to > check for xf86_ansic functions, as adding a macro for checking > the proper sdk header, and cut&pasting everywhere may not > be the better way, so it checks XORG_VERSION_CURRENT, but > that value has not yet been updated in git master... > this one was pushed as e807e5a88af379cad14331b787ed32a45553f8f3 on Jan 30. (In reply to comment #1) > Created an attachment (id=14691) [details] > 0002-Don-t-call-xf86GetErrno-instead-use-errno-directly.patch I'm not sure about the whole XORG_VERSION_CURRENT > (((1) * 10000000) + ((4) * 100000) + ((99) * 1000) + 2). Isn't there a saner macro around?
On Thu, Feb 28, 2008 at 23:18:59 -0800, bugzilla-daemon@freedesktop.org wrote: > --- Comment #2 from Peter Hutterer <peter@cs.unisa.edu.au> 2008-02-28 23:18:58 PST --- > I'm not sure about the whole > XORG_VERSION_CURRENT > (((1) * 10000000) + ((4) * 100000) + ((99) * 1000) + 2). > > Isn't there a saner macro around? > XORG_VERSION_CURRENT > XORG_VERSION_NUMERIC(1,4,99,2,0)
Created attachment 15693 [details] [review] 0001-Don-t-call-xf86GetErrno-instead-use-errno-directl.patch I think it would be better to just not check for Xorg version, as it is what is done everywhere else, and this patch should also work with very releases, at least as far as the dlloader is used.
(In reply to comment #4) > Created an attachment (id=15693) [details] > 0001-Don-t-call-xf86GetErrno-instead-use-errno-directl.patch > > I think it would be better to just not check > for Xorg version, as it is what is done everywhere > else, and this patch should also work with very > releases, at least as far as the dlloader is used. > pushed, thanks.
I think the last push closed this bug.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.