Bug 14728 - libXp ansification
Summary: libXp ansification
Status: RESOLVED NOTABUG
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/other (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-02-28 16:18 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-23 15:19 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-libXp-ansification.patch (5.27 KB, patch)
2008-02-28 16:18 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Adjust-some-null-character-comparisons.patch (1.42 KB, patch)
2008-02-28 16:18 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-02-28 16:18:24 UTC
Created attachment 14671 [details] [review]
0001-libXp-ansification.patch

and some minor other fixes.
Comment 1 Paulo César Pereira de Andrade 2008-02-28 16:18:46 UTC
Created attachment 14672 [details] [review]
0002-Adjust-some-null-character-comparisons.patch
Comment 2 Paulo César Pereira de Andrade 2008-07-23 12:38:30 UTC
  Not really a bug, just ansification and prototypes fixes.
Comment 3 James Cloos 2008-07-23 12:50:34 UTC
Were we not accepting ansification patches?

I’m not sure it is NOTABUG.
Comment 4 Paulo César Pereira de Andrade 2008-07-23 13:01:22 UTC
  I originally made the bug report, so I am closing it :-)

  I am just closing as NOTABUG trivial patches, so that
those that address real problems have a higher change of
being reviewed/applied (at some point I had more than
100 open bug reports).

  There are some "nontrivial" ansification patches, like
the libXfont and libX11 ones, but I should remake them
as patches that only address real problems, otherwise
just close the bug reports.

  A sample "trivial" one is libXpm ansification, it is
trivial in the sense that it is easy to make because there
are not type promotions, and all the code follows a single
"pattern" (indentation style, clear code, etc), just a lot
of work because there is a lot of code to convert...
Comment 5 James Cloos 2008-07-23 15:19:16 UTC
> I originally made the bug report, so I am closing it :-)

That obviously does make a difference. :)

Unfortunately the email interface (otherwise *much* easier to use)
doesn’t give any indication of that....


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.