Bug 14727 - libXpm ansification
Summary: libXpm ansification
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xpm (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2008-02-28 15:46 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-23 13:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-libXpm-ansification.patch (59.69 KB, patch)
2008-02-28 15:46 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-02-28 15:46:55 UTC
Created attachment 14670 [details] [review]

This patch should be easy and cause no side effects as only "non promotable"
types are ever used.
Comment 1 Paulo César Pereira de Andrade 2008-07-23 13:28:42 UTC
  Patch is not small, so requires some time to do
it "by hand", but is trivial, as there are no type
promotions (and talking for memory from when I
reviewed the patch) neither "traps" that can allow
easily redefining a prototype incorrectly by swaping
order of arguments, example of a "trap":

type foo(a, b, c)
    type a;
    type c;
    type b;

where a patch by hand could just change it to:

type foo(
    type a,
    type c,
    type b)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.