Bug 14720 - libX11 ansification and bug fixes
Summary: libX11 ansification and bug fixes
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-02-28 11:55 UTC by Paulo César Pereira de Andrade
Modified: 2009-02-02 11:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-libX11-ansification.patch (47.72 KB, patch)
2008-02-28 11:55 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-WORD64-compile-fix.-This-bug-catched-on-a-overview-o.patch (997 bytes, patch)
2008-02-28 11:55 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0003-Don-t-add-prototypes-for-functions-that-don-t-exist.patch (1.34 KB, patch)
2008-02-28 11:56 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0004-Allow-multiple-inclusions-of-cursorfont.h-cosmetic.patch (818 bytes, patch)
2008-02-28 11:56 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0004-Allow-multiple-inclusions-of-cursorfont.h-cosmetic.patch (818 bytes, patch)
2008-02-28 11:56 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0005-Compile-warning-fix.-Cast-a-XIM-to-a-Xim.patch (730 bytes, patch)
2008-02-28 11:58 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0006-Fix-some-address-of-var-will-always-evaluate-as-t.patch (1.69 KB, patch)
2008-02-28 11:58 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0007-Add-ending-newline-to-some-manpage-files.patch (1.57 KB, patch)
2008-02-28 11:59 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-libX11-ansification.patch (51.41 KB, patch)
2008-02-28 12:49 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-libX11-ansification.patch (52.22 KB, patch)
2008-03-13 19:26 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0007-Add-ending-newline-to-some-manpage-files.patch (1.57 KB, patch)
2008-03-13 19:27 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-libX11-ansification.patch (52.23 KB, patch)
2008-05-10 10:03 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-02-28 11:55:31 UTC
Created attachment 14654 [details] [review]
0001-libX11-ansification.patch

I did not provide a patch for "#if NeedWidePrototypes" 'fication
of the already "ansified" functions because it would possibly generate
binary incompatibilities, but the cases are listed in patch 1.

  Also, did not do a more complete review to ensure no prototypes
of extern functions are in C files or move or at least protect from
multiple inclusion static data defined in header files, etc.
If the current patches are applied, I may extend the work on this.
Comment 1 Paulo César Pereira de Andrade 2008-02-28 11:55:59 UTC
Created attachment 14655 [details] [review]
0002-WORD64-compile-fix.-This-bug-catched-on-a-overview-o.patch
Comment 2 Paulo César Pereira de Andrade 2008-02-28 11:56:20 UTC
Created attachment 14656 [details] [review]
0003-Don-t-add-prototypes-for-functions-that-don-t-exist.patch
Comment 3 Paulo César Pereira de Andrade 2008-02-28 11:56:38 UTC
Created attachment 14657 [details] [review]
0004-Allow-multiple-inclusions-of-cursorfont.h-cosmetic.patch
Comment 4 Paulo César Pereira de Andrade 2008-02-28 11:56:43 UTC
Created attachment 14658 [details] [review]
0004-Allow-multiple-inclusions-of-cursorfont.h-cosmetic.patch
Comment 5 Paulo César Pereira de Andrade 2008-02-28 11:58:17 UTC
Created attachment 14659 [details] [review]
0005-Compile-warning-fix.-Cast-a-XIM-to-a-Xim.patch

  Err, patch 004 added twice, removing it, and also adding patch 5.
Comment 6 Paulo César Pereira de Andrade 2008-02-28 11:58:45 UTC
Created attachment 14660 [details] [review]
0006-Fix-some-address-of-var-will-always-evaluate-as-t.patch
Comment 7 Paulo César Pereira de Andrade 2008-02-28 11:59:11 UTC
Created attachment 14661 [details] [review]
0007-Add-ending-newline-to-some-manpage-files.patch
Comment 8 Paulo César Pereira de Andrade 2008-02-28 12:49:14 UTC
Created attachment 14662 [details] [review]
0001-libX11-ansification.patch

  Remake 0001-libX11-ansification.patch as I typed ^Espace and it ended
up adding a null character and generated an improper patch, i.e. git
tagged src/udcInf.c as a binary file.
Comment 9 Paulo César Pereira de Andrade 2008-03-13 19:26:41 UTC
Created attachment 15103 [details] [review]
0001-libX11-ansification.patch

Remade patch and git-am'ed from current master.
This also "ansifies" two functions that were not ansified in
original patch.

Other patches should apply cleanly, but patch 7 will also be
remade to not add spaces at end of line.

Only remaining warnings are:
imRm.c: In function '_XimDefaultIMValues':
imRm.c:411: warning: assignment discards qualifiers from pointer target type
imRm.c: In function '_XimDefaultICValues':
imRm.c:448: warning: assignment discards qualifiers from pointer target type
Comment 10 Paulo César Pereira de Andrade 2008-03-13 19:27:40 UTC
Created attachment 15104 [details] [review]
0007-Add-ending-newline-to-some-manpage-files.patch

Add ending newline but don't add spaces after it.
Comment 11 Paulo César Pereira de Andrade 2008-05-10 10:03:29 UTC
Created attachment 16465 [details] [review]
0001-libX11-ansification.patch

  Patch remade as it doesn't apply cleanly anymore,
due to change in src/locking.c.
Comment 12 Paulo César Pereira de Andrade 2009-02-02 11:10:00 UTC
  Some patches were already applied, but everything
is now in git master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.