Created attachment 14591 [details] [review] 0001-libSM-ansification.patch Like the libICE, these should have no problems as there should not exist type promotion. Only problem not handled is definition of prototypes of internal libICE functions. This probably should also be handled in libICE, to have a single header files to define those private functions, instead of local globals.h header file.
Created attachment 14592 [details] [review] 0002-Allow-globals.h-to-be-included-by-multiple-files.patch
Created attachment 14593 [details] [review] 0003-Add-missing-prototypes.patch
Created attachment 14594 [details] [review] 0004-GCC-warning-fix-cast-const-char-to-char-to-m.patch
Created attachment 15102 [details] [review] 0001-libSM-ansification.patch Missed one K&R definition, found now, when compiling with -Wold-style-definition
This was one of the first ansification patches I sent, and the description already tells that it is not complete because some prototypes defined in C source files were not moved to globals.h. Other than that, the patch is trivial, but doesn't address any real bugs.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.