Bug 14684 - libXau, ansify functions under #ifdef K5AUTH
Summary: libXau, ansify functions under #ifdef K5AUTH
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xau (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2008-02-26 09:19 UTC by Paulo César Pereira de Andrade
Modified: 2009-02-02 11:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

0001-Ansify-2-remaining-K-R-prototype-functions.patch (1.24 KB, patch)
2008-02-26 09:19 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-02-26 09:19:52 UTC
Created attachment 14586 [details] [review]

Just for coherence as all remaining libXau code is
already "ansified".
Comment 1 Alan Coopersmith 2008-02-26 09:35:21 UTC
Are these functions able to be compiled any more or are they as broken as
the ones recently removed from the server?   (i.e. do they use current
Kerberos5 API, or only the early 90's version?)
Comment 2 Paulo César Pereira de Andrade 2008-02-26 09:55:03 UTC
  I dont have experience with kerberos, but looking at
function calls, and definitions from the kerberos 5 devel
package in Mandriva, I notice that the calls in libXau
are incorrect, as all functions/macros receive a
krb5_context pointer as first argument.

  So maybe it should be aswell just removed if the
Server side has been already removed, otherwise, fixing
it would probably be better...

Comment 3 Paulo César Pereira de Andrade 2009-02-02 11:28:56 UTC
  Corrected in git master by removing the
old kerberos api implementation.

  Since support was already removed from the
X Server then, the logical step for libXau
is to also remove it, but the proper solution
should really be to update both X Server and
libXau to today's Kerberos 5 api.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.