Bug 1229 - KEYBOARD symbol undefined for non-loadable server when using old keyboard driver
Summary: KEYBOARD symbol undefined for non-loadable server when using old keyboard driver
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/Keyboard (show other bugs)
Version: git
Hardware: All All
: high normal
Assignee: Xorg Project Team
QA Contact:
URL: http://freedesktop.org/pipermail/rele...
Depends on:
Blocks: 269 351
  Show dependency treegraph
Reported: 2004-08-29 06:54 UTC by Kristian Høgsberg
Modified: 2007-12-16 17:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Always define KEYBOARD (661 bytes, patch)
2004-08-29 06:59 UTC, Kristian Høgsberg
no flags Details | Splinter Review

Description Kristian Høgsberg 2004-08-29 06:54:50 UTC
See the email thread in

A better fix would be to rename the input/keyboard directory to input/kbd so it
matches the name of driver it contains.  input/Imakefile should then be changed
so it has 

  #if UseDeprecatedKeyboardDriver

but we probably shouldn't rename directories at this point ;-)
Comment 1 Kristian Høgsberg 2004-08-29 06:59:22 UTC
Created attachment 761 [details] [review]
Always define KEYBOARD

This patch removes the #if / #endif around the KEYBOARD definition so it always
present.  When building with LoadableServer NO and UseDeprecatedKeyboardDriver
YES, two entries in the xf86InputDriverList will have .driverName = "keyboard",
but the XF86KEYBOARD will appear first and take precedence as it should.
Comment 2 Kevin E. Martin 2004-08-29 14:06:39 UTC
Okay, I've tested this patch, and it appears to work fine for me with both the
loader and no-loader cases.  Checking in and closing.

We should revisit this after the release and consider renaming the keyboard dir.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.