Bug 12286 - fb access incorrectly wrapped for fbPolyArc
Summary: fb access incorrectly wrapped for fbPolyArc
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on: xorg-7.3
Blocks:
  Show dependency tree / graph
 
Reported: 2007-09-05 01:30 UTC by Alan Hourihane
Modified: 2007-09-27 07:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
fbPolyArc fix (1.18 KB, patch)
2007-09-05 01:30 UTC, Alan Hourihane 		no flags Details | Splinter Review
slight update to the last one (1.27 KB, patch)
2007-09-05 01:32 UTC, Alan Hourihane 		no flags Details | Splinter Review
stop rushing.... (1.27 KB, patch)
2007-09-05 01:33 UTC, Alan Hourihane 		no flags Details | Splinter Review
Fixes for EXA to avoid the problem also (799 bytes, patch)
2007-09-05 01:46 UTC, Alan Hourihane 		no flags Details | Splinter Review
an update to fix braces This includes both the fb & EXA fixes. (2.17 KB, patch)
2007-09-05 11:38 UTC, Alan Hourihane 		no flags Details | Splinter Review
Show Obsolete (4) View All

Description Alan Hourihane 2007-09-05 01:30:26 UTC 
fbPolyArc calls mi functions which can end up calling the accelerated driver. 

This patch demonstrates what needs to happen to fbPolyArc to it's wrapped/unwrapped correctly.

I've just thrown this together in the hope someone can review for the 7.3 release and get this fixed as it can cause rendering glitches.
Comment 1 Alan Hourihane 2007-09-05 01:30:52 UTC 
Created attachment 11425 [details] [review]
fbPolyArc fix

here's the patch
Comment 2 Alan Hourihane 2007-09-05 01:32:50 UTC 
Created attachment 11426 [details] [review]
slight update to the last one

update to the last.
Comment 3 Alan Hourihane 2007-09-05 01:33:48 UTC 
Created attachment 11427 [details] [review]
stop rushing....
Comment 4 Alan Hourihane 2007-09-05 01:46:59 UTC 
Created attachment 11429 [details] [review]
Fixes for EXA to avoid the problem also

This patch is for EXA which bumps into similar issues caused by fbPolyArc.

We can't rely on this path as fbPolyArc can call out to mi anyway. So let's just call miPolyArc for all cases.
Comment 5 Alan Hourihane 2007-09-05 03:20:24 UTC 
Note, these haven't been committed to master either.
Comment 6 Colin Harrison 2007-09-05 10:51:53 UTC 
The 'if else' syntax is wrong due to missing brackets, for me.
Comment 7 Alan Hourihane 2007-09-05 11:38:23 UTC 
Created attachment 11437 [details] [review]
an update to fix braces

This includes both the fb & EXA fixes.

Yeah, in the rush to get something coherent I didn't build test, and it ended up in-coherent. Sorry.

Attached is an updated patch.
Comment 8 Michel Dänzer 2007-09-25 00:41:20 UTC 
EXA part pushed to master and no-pci-rework branches.
Comment 9 Alan Hourihane 2007-09-27 07:02:06 UTC 
Commit the fb part and add FB_ACCESS_WRAPPER around them as well.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.