Bug 12079 - x11proto/keysymdef.h and libX11/src/KeyBind.c have gotten out of sync
Summary: x11proto/keysymdef.h and libX11/src/KeyBind.c have gotten out of sync
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Whiteboard: 2011BRB_Reviewed
Keywords: i18n
Depends on:
Reported: 2007-08-20 21:30 UTC by James Cloos
Modified: 2018-08-10 20:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description James Cloos 2007-08-20 21:30:33 UTC
A comment in x11proto/xkeysymdef.h says to keep it in sync with xc/lib/X11/KeyBind.c (now libX11/src/KeyBind.c) and the protocol definition in xc/doc/specs/XProtocol/X11.keysyms (now xorg-docs/specs/XProtocol/X11.keysyms).

I’m preparing a patch for the latter.

As for KeyBind.c, I see two issues:

First, it #defines a subset of the #ifdefs in keysymdef.h before explicitly #including it.  That could be cured by #including keysym.h instead, which already does that heavy lifting, and is more likely to be kept in sync with keysymdef.h.

Second, it has code to do case mapping, but that — according to the comments — has not been updated to reflect characters added to the UCS since Unicode version 4.0.  That likely should be expanded to include the new characters.
Comment 1 Jeremy Huddleston Sequoia 2011-10-03 01:02:37 UTC
Did you ever prepare that patch you mentioned?  Is this still an issue with 
current deliverables?
Comment 2 James Cloos 2011-10-03 10:47:00 UTC
I’ll have to do some archeology....
Comment 3 GitLab Migration User 2018-08-10 20:09:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.