Bug 11881 - atifragshader.c falsy test on GL_SWIZZLE_STR_ATI<=swizzle<=GL_SWIZZLE_STQ_DQ_ATI
Summary: atifragshader.c falsy test on GL_SWIZZLE_STR_ATI<=swizzle<=GL_SWIZZLE_STQ_DQ_ATI
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-08-07 02:38 UTC by Roland "Test-tools" Bär
Modified: 2007-08-07 13:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
corrected logic (1.42 KB, patch)
2007-08-07 02:39 UTC, Roland "Test-tools" Bär
Details | Splinter Review

Description Roland "Test-tools" Bär 2007-08-07 02:38:51 UTC
That tests can't be true: 
   if ((swizzle < GL_SWIZZLE_STR_ATI) && (swizzle > GL_SWIZZLE_STQ_DQ_ATI)) {
Please apply attached patch, seams to me what was intended
Comment 1 Roland "Test-tools" Bär 2007-08-07 02:39:33 UTC
Created attachment 11031 [details] [review]
corrected logic
Comment 2 Brian Paul 2007-08-07 13:44:49 UTC
fixed in git.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.