Bug 11859 - Mem leak fixes for randr
Summary: Mem leak fixes for randr
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All All
: lowest trivial
Assignee: Keith Packard
QA Contact: Xorg Project Team
Keywords: janitor, patch
Depends on:
Reported: 2007-08-06 02:02 UTC by Roland "Test-tools" Bär
Modified: 2009-10-13 13:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

trivial patch (1.68 KB, patch)
2007-08-06 02:02 UTC, Roland "Test-tools" Bär
no flags Details | Splinter Review

Description Roland "Test-tools" Bär 2007-08-06 02:02:15 UTC
Please apply attached patch.
Comment 1 Roland "Test-tools" Bär 2007-08-06 02:02:53 UTC
Created attachment 11006 [details] [review]
trivial patch
Comment 2 Daniel Stone 2007-09-23 08:52:04 UTC
Keith, is this okay?
Comment 3 Keith Packard 2007-09-23 14:00:28 UTC
Most of these patches are incorrect.

AddResource calls the delete function on failure.

prop_value is not an allocated object.

num_values parity can be checked before the property is created. Alternatively, use RRDestroyOutputProperty instead of xfree to free it, but only if it was added (if (add) RRDestroyOutputProperty (prop);)
Comment 4 Eric Anholt 2009-01-30 21:32:06 UTC
Comment on attachment 11006 [details] [review]
trivial patch

mark rejected patch as obsolete.
Comment 5 Eric Anholt 2009-10-13 13:25:24 UTC
Feedback timeout.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.