Bug 11139 - minor code cleanup
Summary: minor code cleanup
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/savage (show other bugs)
Version: git
Hardware: Other All
: medium minor
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: janitor
Depends on:
Reported: 2007-06-04 13:45 UTC by Tormod Volden
Modified: 2008-02-24 18:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

removes unnecessary block and code (699 bytes, patch)
2007-06-04 13:46 UTC, Tormod Volden
no flags Details | Splinter Review

Description Tormod Volden 2007-06-04 13:45:05 UTC
This block in src/savage_dri.c looks suspiciously like cruft. I can not make any sense of that block and its local, unused variable:

1118    {
1119       unsigned int shift = 0;
1121       if(pSAVAGEDRI->width > 1024)
1122         shift = 1; 
1124       pSAVAGEDRI->aperturePitch = psav->ulAperturePitch;
1125    }

The last time anyone touched this block was commit 54a78b4d252ba06dd520c5d43ad55b31323408ec but this has been like this since as long as git can tell.
Comment 1 Tormod Volden 2007-06-04 13:46:35 UTC
Created attachment 10178 [details] [review]
removes unnecessary block and code

I guess it should be just like this.
Comment 2 Adam Jackson 2008-02-24 18:47:23 UTC
Fixed in git, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.