In file included from src/gallium/auxiliary/os/os_thread.h:42:
src/util/u_thread.h:64:39: error: too many arguments to function call, expected 1, have 2
9c411e020d164563fb6fcd92a28a435277bf0745 is the first bad commit
Author: Matt Turner <firstname.lastname@example.org>
Date: Wed Jul 24 18:26:49 2019 -0700
util: Drop preprocessor guards for glibc-2.12
glibc-2.12 was released in 2010. No one is building new Mesa against 9
year old glibc, and removing these checks allows the code to work on
other C libraries like musl.
Acked-by: Eric Engestrom <email@example.com>
Looking at the man page (http://man7.org/linux/man-pages/man3/pthread_setname_np.3.html), pthread_setname_np definitely takes two parameters. Dare I even ask what pthreads library this is?
512 __API_AVAILABLE(macos(10.6), ios(3.2))
513 int pthread_setname_np(const char*);
Aggravatingly, Mac OS's version takes only one parameter it seems. See https://gitlab.haskell.org/ghc/ghc/issues/9684 for example of other projects running into this.
Fixed with https://gitlab.freedesktop.org/mesa/mesa/commit/dcf9d91a80ee76f46e162afef9bd1b2ddb53ecc3