Bug 111199 - Bug in dither.depth property set: Value compared to dither.mode instead of dither.depth
Summary: Bug in dither.depth property set: Value compared to dither.mode instead of di...
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/nouveau (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Nouveau Project
QA Contact: Xorg Project Team
Keywords: janitor
Depends on:
Reported: 2019-07-23 09:38 UTC by Max
Modified: 2019-12-04 09:50 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Max 2019-07-23 09:38:33 UTC
There is probably a bug in dither.depth property set cause its value compared with dither.mode:

if (property == disp->dithering_mode) {
    if (asyc->dither.mode != val) {
        asyc->dither.mode = val;
        asyc->set.dither = true;
} else
if (property == disp->dithering_depth) {
    if (asyc->dither.mode != val) { //Should be dither.depth
        asyc->dither.depth = val;
        asyc->set.dither = true; //triggers dithering regardless of dither.mode set above. Copy/Paste from above? Should be removed?
Comment 1 Martin Peres 2019-12-04 09:50:49 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/issues/496.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.