Bug 107270 - shader_test.py GLES and GL shaders in the same command!
Summary: shader_test.py GLES and GL shaders in the same command!
Alias: None
Product: piglit
Classification: Unclassified
Component: infrastructure (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Dylan Baker
QA Contact: Piglit Mailing List
Keywords: regression
Depends on:
Reported: 2018-07-18 07:58 UTC by Vinson Lee
Modified: 2018-07-19 15:11 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description Vinson Lee 2018-07-18 07:58:38 UTC
Traceback (most recent call last):
  File "tests/serializer.py", line 151, in <module>
  File "tests/serializer.py", line 146, in main
    profile = load_test_profile(args.input, python=True)
  File "tests/../framework/profile.py", line 585, in load_test_profile
    mod = importlib.import_module('tests.{0}'.format(name))
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "tests/../tests/quick_shader.py", line 28, in <module>
    from .shader import profile as _profile
  File "tests/../tests/shader.py", line 79, in <module>
    profile.test_list[group] = MultiShaderTest.new(files, installedfiles)
  File "tests/../framework/test/shader_test.py", line 253, in new
    'GLES and GL shaders in the same command!\n'
framework.exceptions.PiglitInternalError: An internal error occurred:
GLES and GL shaders in the same command!
Cannot pick a shader_runner binary!
Comment 1 Sergii Romantsov 2018-07-18 12:52:16 UTC
Hello, Vinson.
Could you, please, try in piglit directory:
'make clean'
and rebuild piglit.
Comment 2 Sergii Romantsov 2018-07-18 13:28:38 UTC
Sorry, Vinson.
That was wrong suggestion.

2f02cf0d4c2d7e901415d2325200deccc4230123 is the first bad commit
commit 2f02cf0d4c2d7e901415d2325200deccc4230123
Author: Dylan Baker <dylan@pnwbakers.com>
Date:   Wed Mar 28 14:50:31 2018 -0700

    Generate xml for builtin profiles
    This creates and installs xml for all builtin profiles. Using these
    profiles I see startup times of ~1 second as opposed to more than 10
    with current master, and runtimes that drop by ~1 minute.
    v2: - Fix compilation with make. v1 only worked with ninja.
    Tested-by: Rafael Antognolli <rafael.antognolli@intel.com>

:100644 100644 dc80ece9a2152da2b19bcad727ff88479a19c061 db047b4b2fd4d5a4db0d8eff43a4ff0d0ec42a40 M	CMakeLists.txt
:040000 040000 aa396d17baaca95d4d3c62079d36bd4048518979 dcfa1e0d459cad0923348eb2788b0df94ad8ae01 M	tests
Comment 3 Dylan Baker 2018-07-18 19:06:38 UTC
You might be interested in this patch:
Comment 4 Michel Dänzer 2018-07-19 08:52:03 UTC
Dylan's patch fixes the problem for me.

Note that the bisect result in comment 2 was incorrect (the failure was introduced by commit 359640285258 "EXT_shader_framebuffer_fetch: Add test cases specific to desktop GL."), probably due to stale files in generated_tests getting picked up with older commits.
Comment 5 Sergii Romantsov 2018-07-19 11:16:18 UTC
Thanks, Michel.
Seems you are right and it was some mess in my repo.
Comment 6 Mark Janes 2018-07-19 15:11:46 UTC
fixed by 21c93b6c1a176ec2ac26d3f4207f5e85c665c98d

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.