Bug 105471 - [g33] [bisected] dEQP-GLES2.functional.shaders failures
Summary: [g33] [bisected] dEQP-GLES2.functional.shaders failures
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Mathias Fröhlich
QA Contact: Intel 3D Bugs Mailing List
Keywords: bisected, regression
Depends on:
Reported: 2018-03-13 01:08 UTC by Clayton Craft
Modified: 2018-03-16 05:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attempt of a fix. (2.48 KB, patch)
2018-03-13 08:15 UTC, Mathias Fröhlich
Details | Splinter Review

Description Clayton Craft 2018-03-13 01:08:05 UTC
There are approximately 2300 new dEQP test failures on g33 in the Mesa CI. The full list of failing tests can be seen here: https://craftyguy.net/paste/Kfh9QQWi

This has been bisected to the following commit:

commit 64d2a20480547d5897fd9d7b8fd306f2625138cb
Author: Mathias Fröhlich <mathias.froehlich@web.de>
Date:   Sun Mar 4 18:15:53 2018 +0100

    mesa: Make gl_vertex_array contain pointers to first order VAO members.
Comment 1 Mathias Fröhlich 2018-03-13 08:15:39 UTC
Created attachment 138068 [details] [review]
Attempt of a fix.

Does the attached patch bring us back to the old fail count?


Comment 2 Mark Janes 2018-03-16 05:55:17 UTC
fixed by
Author:     Mathias Fröhlich <mathias.froehlich@gmx.net>

vbo: Correctly handle source arrays in vbo_split_copy.

The original approach did optimize away a bit too many fields.
Restablish the pointer into the original array and correctly feed that

Reviewed-by: Brian Paul <brianp@vmware.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105471
Fixes: 64d2a20480547d5897fd9d7b8fd306f2625138cb
    mesa: Make gl_vertex_array contain pointers to first order VAO members.
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@web.de>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.