Bug 103658 - addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression
Summary: addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
Keywords: bisected, regression
Depends on:
Reported: 2017-11-10 05:44 UTC by Vinson Lee
Modified: 2017-11-20 16:29 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

build addrlib with C++11 (1.14 KB, patch)
2017-11-15 11:53 UTC, Nicolai Hähnle
Details | Splinter Review

Description Vinson Lee 2017-11-10 05:44:46 UTC
mesa: cd6f79a71d75d5d756176a03f04c4442c0ef9e7f (master 17.4.0-devel)

clang build error

  CXX      addrlib/gfx9/addrlib_libamdgpu_addrlib_la-gfx9addrlib.lo
addrlib/gfx9/gfx9addrlib.cpp:727:50: error: expected expression
        const CoordEq* pMetaEq = GetMetaEquation({0, fmaskElementBytesLog2, 0, pIn->cMaskFlags,
Comment 1 Nicolai Hähnle 2017-11-14 16:33:21 UTC
Looks like you're not building with C++11 enabled? The recent changes to addrlib require that.
Comment 2 Vinson Lee 2017-11-14 21:46:18 UTC
commit 7f33e94e43a647d71a9f930cf3180e5abb529edd
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Tue Nov 7 00:56:13 2017 +0100

    amd/addrlib: update to latest version
    This uses C++11 initializer lists.
    I just overwrote all Mesa files with internal addrlib and discarded
    hunks that we should probably keep, but I might have missed something.
    The code depending on ADDR_AM_BUILD is removed. We can add it back next
    time if needed.
    Acked-by: Nicolai Hähnle <nicolai.haehnle@amd.com>

:040000 040000 c055da298572eb64e857a1907496ccf7e92c2920 06079de7e3cf90c76f245612b96c12e6a369a42d M	src
bisect run success
Comment 3 Nicolai Hähnle 2017-11-15 11:53:58 UTC
Created attachment 135484 [details] [review]
build addrlib with C++11

Does the attached patch help?
Comment 4 Nicolai Hähnle 2017-11-20 16:29:51 UTC
commit abeded1cacb5a17a422cb3788153814ed2e01ecb
Author: Nicolai Hähnle <nicolai.haehnle@amd.com>
Date:   Wed Nov 15 12:51:23 2017 +0100

    amd: build addrlib with C++11

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.