| Summary: | Unrelated stderr output with DBUS_VERBOSE | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | core | Assignee: | D-Bus Maintainers <dbus> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | CC: | ralf.habacker |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Attachments: | Do not show unrelated stderr output with DBUS_VERBOSE when using windows debug port as output channel. | ||
|
Description
Ralf Habacker
2017-02-10 07:35:18 UTC
Created attachment 129466 [details] [review] Do not show unrelated stderr output with DBUS_VERBOSE when using windows debug port as output channel. Comment on attachment 129466 [details] [review] Do not show unrelated stderr output with DBUS_VERBOSE when using windows debug port as output channel. Review of attachment 129466 [details] [review]: ----------------------------------------------------------------- Seems reasonable to me. You might want to reword the first line of the commit message though so it’s a bit shorter. (In reply to Philip Withnall from comment #2) > Seems reasonable to me. And me. (In reply to Philip Withnall from comment #3) > You might want to reword the first line of the commit message though so it’s > a bit shorter. (The first line is the entire commit message, in fact.) Yes please. Perhaps something more like this: Only print timestamps on stderr if verbose messages will go there On Windows, dbus can be configured to send DBUS_VERBOSE messages to the Windows debug port instead of stderr. If we're in that configuration, we already avoided printing thread information to stderr before each verbose message; do the same for timestamps. committed to git master with mentioned commit message change applied |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.