| Summary: | [softpipe] piglit arb_direct_state_access-texunits regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED DUPLICATE | QA Contact: | mesa-dev |
| Severity: | normal | ||
| Priority: | medium | CC: | brianp, lemody |
| Version: | git | Keywords: | bisected, regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
mesa: bf7b6fd3fd6d98305d64ee6224ca9f9e7ba48444 (master 11.1.0-devel) $ ./bin/arb_direct_state_access-texunits -auto GL_RENDERER = Gallium 0.4 on softpipe GL_MAX_TEXTURE_COORDS = 8 GL_MAX_TEXTURE_IMAGE_UNITS = 18 GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS = 18 GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS = 54 Mesa: User error: GL_INVALID_VALUE in glBindTextureUnit(unit=54) Unexpected GL error: GL_INVALID_VALUE 0x501 (Error at piglit/tests/spec/arb_direct_state_access/texunits.c:124) Expected GL error: GL_INVALID_OPERATION 0x502 PIGLIT: {"result": "fail" } a9408f3ca14f2fb6286bd66bad06ee1bde0d8697 is the first bad commit commit a9408f3ca14f2fb6286bd66bad06ee1bde0d8697 Author: Brian Paul <brianp@vmware.com> Date: Wed Sep 30 11:37:16 2015 -0600 mesa: remove _mesa_get_tex_unit_err() and fix error handling This helper was only called from _mesa_BindTextureUnit(). It's simpler to just inline it. The error check / code / message in the helper was incorrect. It was written for glBindTextures(), not glBindTextureUnit(). The correct error for a bad texture unit number is GL_INVALID_VALUE. The error message now reports the unit number rather than a GL_TEXTUREi enum. Fixes a failure in piglit's arb_direct_state_access-bind-texture-unit test. Reviewed-by: Tapani Pälli <tapani.palli@intel.com> :040000 040000 7d921525c01aef94abfb26cc232d225ebe5f50af 27e5bf59206f1906b3654aa6da59d70968234f6c M src bisect run success