| Summary: | avoid implicit declarations on mingw | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | review? | ||
| i915 platform: | i915 features: | ||
| Attachments: |
dbus-monitor: use _dbus_get_real_time instead of gettimeofday
dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX |
||
|
Description
Simon McVittie
2015-03-04 18:52:03 UTC
Created attachment 114003 [details] [review] dbus-monitor: use _dbus_get_real_time instead of gettimeofday gettimeofday is implicitly declared (i.e. not in our #include'd header files) when cross-compiling for on Windows. Now that fd.o#83115 has been fixed, using _dbus functions is not a problem. Created attachment 114004 [details] [review] dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX We close() the fd after we have printed it, but close() isn't standard functionality on Windows. Unix FD-passing is never going to work on non-Unix platforms anyway. Comment on attachment 114003 [details] [review] dbus-monitor: use _dbus_get_real_time instead of gettimeofday Review of attachment 114003 [details] [review]: ----------------------------------------------------------------- looks good Comment on attachment 114004 [details] [review] dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX Review of attachment 114004 [details] [review]: ----------------------------------------------------------------- looks good Thanks, fixed in git for 1.9.16 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.