| Summary: | [PATCH] configure: GNOME_COMMON_INIT: command not found | ||
|---|---|---|---|
| Product: | udisks | Reporter: | Yevhen Kyriukha <kirgene> |
| Component: | general | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | medium | CC: | david |
| Version: | unspecified | Keywords: | patch |
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch
0001-Do-not-use-deprecated-GNOME_.patch |
||
Created attachment 95838 [details] [review] 0001-Do-not-use-deprecated-GNOME_.patch Well, I'd like to drop all GNOME_ things, because they fail all. All marked as deprecated. I created patch, based on yours, which drops all 4 lines of GNOME_ more than 2 months since first reported (In reply to comment #1) > Created attachment 95838 [details] [review] [review] > 0001-Do-not-use-deprecated-GNOME_.patch > > Well, I'd like to drop all GNOME_ things, because they fail all. All marked > as deprecated. > > I created patch, based on yours, which drops all 4 lines of GNOME_ Removing GNOME_COMMON_INIT is correct because it’s deprecated and (critically) the ACLOCAL_AMFLAGS variable it sets is already correctly set in Makefile.am Removing GNOME_MAINTAINER_MODE_DEFINES is also correct because it’s also deprecated. Removing GNOME_DEBUG_CHECK is correct because it’s not used (it defines GNOME_ENABLE_DEBUG which is not used in the C). Removing GNOME_COMPILE_WARNINGS is *not* correct because that will disable a huge number of compilation warnings when building the code. The correct fix here is for you to install gnome-common. It is a required build dependency of udisks. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 91539 [details] Patch I get an error during configure stage: GNOME_COMMON_INIT: command not found That's because GNOME_COMMON_INIT is deprecated and should be removed from configure.ac. I've attached a patch that fixes this issue.