Bug 68601

Summary:	fails to build with a modern GNU linker
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	GLib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	dcbw, rob.taylor, walters
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	tests: fix under-linking Avoid underlinking internal library libdbus-gtool.la

Description Simon McVittie 2013-08-27 11:23:48 UTC

Created attachment 84697 [details] [review]
tests: fix under-linking

---

The test for errors uses dbus_set_error() so it should link -ldbus-1.

Comment 1 Simon McVittie 2013-08-27 12:18:16 UTC

Created attachment 84703 [details] [review]
Avoid underlinking internal library libdbus-gtool.la

Anything that links libdbus-gtool needs to pull in GLib/GObject,
and the order matters (things that libdbus-gtool depends on must
appear after libdbus-gtool itself). libtool understands this, but
only if you tell it the full dependencies.

This broke compilation of test-dbus-glib.exe when cross-compiling
for 32-bit Windows with mingw-w64 (GNU tuple: i686-w64-mingw32).

The linking order used here for dependencies is "lowest in the stack
first", as recommended by the GStreamer documentation.

---

Vaguely related to the above.

Comment 2 Simon McVittie 2013-10-21 11:23:23 UTC

No review, but nobody has actually said "no" either, in nearly 2 months; so I've just pushed this. Please revert it if you object.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.