| Summary: | Automake 1.13 compatibility, and other trivia | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Use AC_PROG_MKDIR_P instead of deprecated AM_PROG_MKDIR_P
util-cxx: include config.h Make tool tests executable rather than putting sh in TESTS_ENVIRONMENT .gitignore: Automake 1.13 installs /test-driver tp_call_stream_endpoint_get_state: return a TpStreamEndpointState on error |
||
|
Description
Simon McVittie
2013-06-07 17:26:41 UTC
Created attachment 80484 [details] [review] Use AC_PROG_MKDIR_P instead of deprecated AM_PROG_MKDIR_P This means we define MKDIR_P instead of mkdir_p - adjust. Strictly speaking this requires Autoconf 2.59d, but 2.60 is hardly a new innovation (it was released in 2006). Created attachment 80485 [details] [review] util-cxx: include config.h This avoids a deprecation warning for g_type_init(). Created attachment 80486 [details] [review] Make tool tests executable rather than putting sh in TESTS_ENVIRONMENT This makes it possible to run the tool tests under the Automake 1.12+ parallel test harness, which is the default from 1.13 onwards. Created attachment 80487 [details] [review] .gitignore: Automake 1.13 installs /test-driver Created attachment 80488 [details] [review] tp_call_stream_endpoint_get_state: return a TpStreamEndpointState on error TP_MEDIA_STREAM_STATE_DISCONNECTED is from another enum entirely, and will no longer exist in Telepathy 1.0. --- Not really related to anything at all, but it's been gathering dust on a branch for more than a year. Comment on attachment 80484 [details] [review] Use AC_PROG_MKDIR_P instead of deprecated AM_PROG_MKDIR_P Review of attachment 80484 [details] [review]: ----------------------------------------------------------------- ok Comment on attachment 80485 [details] [review] util-cxx: include config.h Review of attachment 80485 [details] [review]: ----------------------------------------------------------------- ok Comment on attachment 80486 [details] [review] Make tool tests executable rather than putting sh in TESTS_ENVIRONMENT Review of attachment 80486 [details] [review]: ----------------------------------------------------------------- Assuming you don't forget +x in git, +1 Comment on attachment 80487 [details] [review] .gitignore: Automake 1.13 installs /test-driver Review of attachment 80487 [details] [review]: ----------------------------------------------------------------- ok Comment on attachment 80488 [details] [review] tp_call_stream_endpoint_get_state: return a TpStreamEndpointState on error Review of attachment 80488 [details] [review]: ----------------------------------------------------------------- ok Thanks, fixed in git for 0.20.3 (the one that actually prevents distcheck in Automake 1.13) and 0.21.1. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.