Bug 5753

Summary:	_cairo_svg_document_finish shouldn't dump doc to memory
Product:	cairo	Reporter:	Dom Lachowicz <domlachowicz>
Component:	svg backend	Assignee:	Emmanuel Pacaud <emmanuel.pacaud>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high	Keywords:	patch
Version:	1.1.1
Hardware:	x86 (IA32)
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	don't dump the doc to memory before saving

Description Dom Lachowicz 2006-01-29 07:18:08 UTC

This is somewhat wasteful, and there was a TODO in the code, so I took the
liberty of reimplementing it. Patch to follow.

Comment 1 Dom Lachowicz 2006-01-29 07:18:37 UTC

Created attachment 4499 [details] [review]
don't dump the doc to memory before saving

Comment 2 Emmanuel Pacaud 2006-01-29 07:36:08 UTC

Thanks for your patch.

     xmlFreeDoc (document->xml_doc);
 
+    xmlFreeNode (document->xml_node_main);
+

Isn't xmlFreeDoc supposed to free all doc structures, including tree ?

Comment 3 Dom Lachowicz 2006-01-29 07:55:27 UTC

Sorry, that last part slipped in from a new patch that I'm working on.

Comment 4 Emmanuel Pacaud 2006-01-30 04:14:32 UTC

Comment on attachment 4499 [details] [review]
don't dump the doc to memory before saving

Ok to commit.

Comment 5 Dom Lachowicz 2006-01-30 05:11:44 UTC

This patch doesn't play well with bug 5314. Please don't commit.

Comment 6 Emmanuel Pacaud 2006-03-16 08:39:24 UTC

Fixed in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.