Bug 51511

The error is:

** (process:10571): ERROR **: Failed to invoke UnsafeDisableLegacyPropertyAccess (org.freedesktop.DBus.GLib.ErrorError): Method invoked for UnsafeDisableLegacyPropertyAccess returned FALSE but did not set error

The offending function:

> void
> my_object_unsafe_disable_legacy_property_access (MyObject *obj)
> {
>   dbus_glib_global_set_disable_legacy_property_access ();
> }

has the wrong signature. It should return gboolean, and have a GError** as a second parameter.

The generated code expects it to return boolean:

  { (GCallback) my_object_unsafe_disable_legacy_property_access, dbus_glib_marshal_my_object_BOOLEAN__POINTER, 2486 },

The fact that the compiler cannot detect this is one of the many design flaws in dbus-glib.

Created attachment 63561 [details] [review]
my_object_unsafe_disable_legacy_property_access: have the  right signature

I'm amazed this ever worked.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=51511
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

---

This is a bug in the regression test, rather than in dbus-glib itself, but it's a symptom of dbus-glib's design flaws. Have I ever mentioned how much better-designed GDBus is?

Comment on attachment 63561 [details] [review]
my_object_unsafe_disable_legacy_property_access: have the  right signature

Review of attachment 63561 [details] [review]:
-----------------------------------------------------------------

Looks correct, thanks!

Fixed in git for 0.102.

Working well now, thank-you for the quick response!