Bug 48771

Summary:	tp_capabilities_supports_ does not check for unknown fixed properties
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=caps
Whiteboard:
i915 platform:		i915 features:

Description Xavier Claessens 2012-04-16 07:41:16 UTC

They should return TRUE only if all fixed properties are known

Comment 1 Xavier Claessens 2012-04-16 07:42:07 UTC

Fix:
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=caps

Some unit tests may help I guess.

Comment 2 Xavier Claessens 2012-04-16 13:14:41 UTC

The branch now has unit test for call

Comment 3 Simon McVittie 2012-04-17 03:00:55 UTC

(In reply to comment #2)
> The branch now has unit test for call

... but not for tubes or RoomList.

Does the RoomList implementation work with all known RoomList CMs?

(It doesn't allow TargetHandleType to be disallowed - the spec says THT should always be fixed, possibly to NONE, except that ContactSearch has it disallowed because we got it wrong in the first couple of implementations. If every CM has THT=NONE in Fixed for RoomList then your implementation is OK.)

Comment 4 Xavier Claessens 2012-04-17 04:07:58 UTC

fixed and merged, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.