Bug 4406

Summary:

DRI isn't really that broken

Product:

xorg

Reporter:

Adam Jackson <ajax>

Component:

Server/Ext/DRI

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

CC:

idr

Version:

git

Hardware:

PowerPC

OS:

Mac OS X (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
dri-not-really-broken-1.patch	none

Description Adam Jackson 2005-09-09 10:32:29 UTC

there's an ugly hack in GL/dri/dri.c to take the drawable lock on every
ValidateTree.  really we only need to do that when we're updating DRI drawables
specifically, but simply undefining DRI_BROKEN doesn't work because the logic is
wrong.

Comment 1 Adam Jackson 2005-09-09 10:38:33 UTC

Created attachment 3212 [details] [review]
dri-not-really-broken-1.patch

move the drawable lock acquisition into ClipNotify and only run it when
touching a DRI window.	mark drawable lock acquisition on a per-screen basis
(instead of once globally, which is wrong) and release it in the BlockHandler
if necessary.

Comment 2 Adam Jackson 2006-01-07 05:02:04 UTC

applied to head, closing

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.