Bug 37790

Summary: remove stub test functions
Product: dbus Reporter: Simon McVittie <smcv>
Component: GLibAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: trivial    
Priority: medium CC: cosimo.alfarano, rob.taylor, will
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://cgit.freedesktop.org/~smcv/dbus-glib/log/?h=no-test-stubs-37790
Whiteboard: review?
i915 platform: i915 features:
Attachments: [PATCH 1/4] dbus-glib-tool: remove regression-test boilerplate which does nothing
[PATCH 2/4] _dbus_gidl_test: remove unused function which does nothing
[PATCH 3/4] Remove _dbus_gutils_test, which didn't test anything
[PATCH 4/4] Remove _dbus_g_proxy_test, which isn't called and doesn't do anything

Description Simon McVittie 2011-05-31 07:19:12 UTC
Created attachment 47368 [details] [review]
[PATCH 1/4] dbus-glib-tool: remove regression-test boilerplate which  does nothing

See patches.
Comment 1 Simon McVittie 2011-05-31 07:19:34 UTC
Created attachment 47369 [details] [review]
[PATCH 2/4] _dbus_gidl_test: remove unused function which does   nothing
Comment 2 Simon McVittie 2011-05-31 07:19:51 UTC
Created attachment 47370 [details] [review]
[PATCH 3/4] Remove _dbus_gutils_test, which didn't test anything
Comment 3 Simon McVittie 2011-05-31 07:20:18 UTC
Created attachment 47371 [details] [review]
[PATCH 4/4] Remove _dbus_g_proxy_test, which isn't called and  doesn't do anything
Comment 4 Will Thompson 2011-06-01 09:08:15 UTC
Review of attachment 47368 [details] [review]:

++
Comment 5 Will Thompson 2011-06-01 09:09:10 UTC
Review of attachment 47369 [details] [review]:

++
Comment 6 Will Thompson 2011-06-01 09:14:05 UTC
Review of attachment 47370 [details] [review]:

++
Comment 7 Will Thompson 2011-06-01 09:17:03 UTC
Review of attachment 47371 [details] [review]:

Go go go.
Comment 8 Simon McVittie 2011-06-01 09:28:02 UTC
Thanks, fixed in git for 0.94

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.