| Summary: | clean up unnecessary bits from build system | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | GLib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | trivial | ||
| Priority: | medium | CC: | cosimo.alfarano, rob.taylor, will |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.freedesktop.org/~smcv/dbus-glib/log/?h=build-trivia-37789 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH 1/5] Add more auto-generated gtkdoc droppings to .gitignore
[PATCH 2/5] Simplify the check for dbus-1 [PATCH 3/5] Remove vestigial dbus-glib-error-*.h and the machinery to generate them [PATCH 4/5] Remove unused DBUS_DAEMONDIR [PATCH 5/5] Remove useless HAVE_GLIB conditional - GLib is mandatory |
||
|
Description
Simon McVittie
2011-05-31 07:02:47 UTC
Created attachment 47363 [details] [review] [PATCH 1/5] Add more auto-generated gtkdoc droppings to .gitignore Created attachment 47364 [details] [review] [PATCH 2/5] Simplify the check for dbus-1 As in commit 0f782b4, omitting the action-if-found and action-if-not-found results in much better error messages if this mandatory dependency isn't found. Nothing checks HAVE_DBUS (as they shouldn't - it's mandatory!), so there's no point in keeping that either. Created attachment 47365 [details] [review] [PATCH 3/5] Remove vestigial dbus-glib-error-*.h and the machinery to generate them This was the only use of DBUS_INCLUDEDIR, so remove that too. Created attachment 47366 [details] [review] [PATCH 4/5] Remove unused DBUS_DAEMONDIR Created attachment 47367 [details] [review] [PATCH 5/5] Remove useless HAVE_GLIB conditional - GLib is mandatory Review of attachment 47363 [details] [review]: ++ Review of attachment 47364 [details] [review]: ++ Review of attachment 47365 [details] [review]: Looks fine! Review of attachment 47366 [details] [review]: Looks fine. Review of attachment 47367 [details] [review]: ++ Thanks, fixed in git for 0.94. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.