Bug 35415

Summary:	Allow the UI to specify extra-identities account paramaters.
Product:	Telepathy	Reporter:	Stef Walter <stefw>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	guillaume.desmottes, sjoerd, stefw
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/stefw/telepathy-gabble.git;a=shortlog;h=refs/heads/extra-identities
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	35410
Bug Blocks:

Description Stef Walter 2011-03-18 05:18:51 UTC

These are used as reference identities when checking the server certificate. These extra identities must result from user choices such as a selection of account type.

Will implement the changes to empathy in another bug.

Comment 1 Stef Walter 2011-03-18 10:11:05 UTC

Added tests in my extra-identities branch (rebased).

Comment 2 Stef Walter 2011-03-21 04:16:39 UTC

Changed param name 'extra-identities' to 'extra-certificate-identities'

Comment 3 Will Thompson 2011-03-31 10:51:45 UTC

Just some style points:

http://git.collabora.co.uk/?p=user/stefw/telepathy-gabble.git;a=commitdiff;h=67837b88d14a70769ec65a159d36e53078b69351#patch3

Why not initialize those variables to NULL when they're declared? Not a big thing though.

+  if (explicit_server != NULL && !tp_str_empty (explicit_server) &&

tp_str_empty checks for NULL so you don't have to.

Also I think this will conflict with the extra style patches you added to the bug 35410 branch.

Comment 4 Will Thompson 2011-03-31 11:11:07 UTC

Merged, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.