| Summary: | configure.ac unnecessarily uses changequote | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | minor | ||
| Priority: | medium | CC: | hp, will |
| Version: | 1.4.x | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/dbus-smcv.git;a=shortlog;h=refs/heads/changequote | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH 1/3] Use square brackets (m4 quoting) instead of changequote
[PATCH 2/3] Remove unnecessary changequote call [PATCH 3/3] Don't compress spaces in CFLAGS and friends |
||
|
Description
Simon McVittie
2011-02-24 09:11:08 UTC
Created attachment 43759 [details] [review] [PATCH 1/3] Use square brackets (m4 quoting) instead of changequote Created attachment 43760 [details] [review] [PATCH 2/3] Remove unnecessary changequote call Nothing in the changequote'd environment uses square brackets anyway. Created attachment 43761 [details] [review] [PATCH 3/3] Don't compress spaces in CFLAGS and friends Not all sed implementations understand "+" with its POSIX extended regular expression semantics, and compressing spaces is purely cosmetic anyway. Let's just drop this. Review of attachment 43759 [details] [review]: I think this makes the section less opaque. So ship it. Review of attachment 43760 [details] [review]: Ship it. Review of attachment 43761 [details] [review]: Fine! Fixed in git for 1.4.8, 1.5.0. Thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.