Bug 32682

Summary:

Inverted check in tseng driver makes it fail to detect card

Product:

xorg

Reporter:

BALATON Zoltan <balaton>

Component:

Driver/Tseng Labs

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

major

Priority:

medium

Version:

git

Hardware:

Other

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Patch correcting typo in TsengGetFbAddress	none

Description BALATON Zoltan 2010-12-27 05:53:26 UTC

Due to a typo in TsengGetFbAddress it is unable to get framebuffer base address and thus fails to load with an error message saying "No valid Framebuffer address in PCI config space" although previously it does print the correct framebuffer address. The attached patch corrects this and makes the driver work again.

Comment 1 BALATON Zoltan 2010-12-27 05:55:05 UTC

Created attachment 41473 [details] [review]
Patch correcting typo in TsengGetFbAddress

Comment 2 Julien Cristau 2011-06-11 03:54:05 UTC

Committed, finally.  Thanks for the patch!

commit 542e65deaf834c3d58c44064206445e4d18f6daa
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date:   Sat Jun 11 12:50:16 2011 +0200

    Fix regression from pciaccess conversion (bug#32682)
    
    Due to a typo in TsengGetFbAddress it is unable to get framebuffer base
    address and thus fails to load with an error message saying "No valid
    Framebuffer address in PCI config space" although previously it does
    print the correct framebuffer address.
    
    Signed-off-by: Julien Cristau <jcristau@debian.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.