Bug 32411

Summary:	tp_g_signal_connect_object should complain if you use unsupported flags
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	minor
Priority:	low	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=refs/heads/trivia
Whiteboard:	review+
i915 platform:		i915 features:

Description Simon McVittie 2010-12-15 06:04:59 UTC

tp_g_signal_connect_object needs specific support for any connect-flags. It currently supports both the flags that exist in GLib (SWAPPED and AFTER) and is documented as such. However, if the GLib developers add more, we should stop people trying to use them until we've added support for them.

This branch makes it return_if_fail if you disobey the documentation.

Comment 1 Jonny Lamb 2010-12-16 00:28:40 UTC

Seems reasonable.

Comment 2 Simon McVittie 2010-12-16 03:18:20 UTC

Thanks, fixed in git for 0.13.10

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.