| Summary: | Ineffective error condition in _dbus_pipe_close | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Christian Dywan <christian> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | major | ||
| Priority: | medium | Keywords: | patch |
| Version: | 1.4.x | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | r+ from walters | ||
| i915 platform: | i915 features: | ||
| Attachments: |
Fix error condition in _dbus_pipe_close
Fix error condition in _dbus_pipe_close #2 |
||
|
Description
Christian Dywan
2010-12-09 06:26:12 UTC
Created attachment 40952 [details] [review] Fix error condition in _dbus_pipe_close Review of attachment 40952 [details] [review]: ::: dbus/dbus-pipe-unix.c @@ +72,3 @@ DBusError *error) { + if (_dbus_close (pipe->fd_or_handle, error)) Shouldn't there be a "!" in there? Review of attachment 40952 [details] [review]: ::: dbus/dbus-pipe-unix.c @@ +72,3 @@ DBusError *error) { + if (_dbus_close (pipe->fd_or_handle, error)) Shouldn't there be a "!" in there? Review of attachment 40952 [details] [review]: ::: dbus/dbus-pipe-unix.c @@ +72,3 @@ DBusError *error) { + if (_dbus_close (pipe->fd_or_handle, error)) Shouldn't there be a "!" in there? Created attachment 40954 [details] [review] Fix error condition in _dbus_pipe_close #2 Oops, indeed. Review of attachment 40954 [details] [review]: Looks good, thanks! (And sorry for the duplicate reviews, splinter was having a bad day) I applied this to master, it'll be in 1.4.4 (or possibly 1.5.0). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.