Bug 31665

Summary:	stop using tp_get_bus() in Salut
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	salut	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/salut-smcv.git;a=shortlog;h=refs/heads/get-bus
Whiteboard:	r+
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	24114

Description Simon McVittie 2010-11-16 09:14:14 UTC

+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Bad™. We can't remove it til we break ABI, but we can at least deprecate it.

Salut still uses this function; it shouldn't.

This Gabble commit should illustrate how to avoid it:

http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commitdiff;h=59319365a14e0f62407a44191b386b1d581083fa

Comment 1 Simon McVittie 2010-11-17 09:49:03 UTC

+patch

Comment 2 Guillaume Desmottes 2010-11-17 10:54:35 UTC

++

Comment 3 Simon McVittie 2010-11-18 03:25:53 UTC

Fixed in git for 0.5.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.