Bug 31664

Summary:	stop using tp_get_bus() in Ring
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	ring	Assignee:	Pekka Pessi <pekka.pessi>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	pekka.pessi
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.freedesktop.org/~smcv/telepathy-ring
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	24114
Attachments:	untested patch

Description Simon McVittie 2010-11-16 09:11:51 UTC

+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Bad™. We can't remove it til we break ABI, but we can at least deprecate it.

telepathy-ring still uses this function; it shouldn't.

This Gabble commit should illustrate how to avoid it:

http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commitdiff;h=59319365a14e0f62407a44191b386b1d581083fa

Comment 1 Simon McVittie 2010-11-17 09:35:47 UTC

An untested branch will be on http://cgit.freedesktop.org/~smcv/telepathy-ring when cgit updates.

Comment 2 Simon McVittie 2010-11-17 09:36:30 UTC

Created attachment 40340 [details] [review]
untested patch

Comment 3 Pekka Pessi 2010-11-24 12:00:35 UTC

The patch looks pretty good, and seems to work with slight changes. Thanks.

Comment 4 Simon McVittie 2010-12-01 03:34:31 UTC

This appears to be fixed in git for 2.1.1, so it no longer blocks deprecating the function. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.