Bug 30726

Summary:	Add 5 HTC Android phones
Product:	media-player-info	Reporter:	Jonathan Ernst <jonathan>
Component:	New device	Assignee:	Martin Pitt <martin.pitt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	Keywords:	NEEDINFO
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch new patch Fix HTC Diamond file to not include other phones IDs Fix HTC Diamond file to not include other phones IDs

Description Jonathan Ernst 2010-10-09 02:20:04 UTC

Created attachment 39299 [details] [review]
patch

HTC Dream
HTC Android Dev Phone 1
HTC G1
HTC Magic

(all have the same ids...)

Comment 1 Jonathan Ernst 2010-10-09 02:22:50 UTC

Forgot the Tattoo too

Comment 2 Jonathan Ernst 2010-10-09 02:23:29 UTC

Created attachment 39300 [details] [review]
new patch

Comment 3 Martin Pitt 2010-10-09 03:23:07 UTC

These are already covered in media-players/htc-diamond.mpi. Perhaps we should just rename the file instead, or split it?

Comment 4 Jonathan Ernst 2010-10-09 09:40:38 UTC

(In reply to comment #3)
> These are already covered in media-players/htc-diamond.mpi. Perhaps we should
> just rename the file instead, or split it?

I have made a new patch against htc-diamond.mpi so only its ID is in the file.

I guess you can then apply the previous patch and the one in Bug #30727 without USB ID conflicts.

Sorry for not checking this earlier and thanks for watching

Comment 5 Jonathan Ernst 2010-10-09 09:41:14 UTC

Created attachment 39307 [details] [review]
Fix HTC Diamond file to not include other phones IDs

Comment 6 Jonathan Ernst 2010-10-09 09:47:05 UTC

Created attachment 39308 [details] [review]
Fix HTC Diamond file to not include other phones IDs

Comment 7 Martin Pitt 2010-10-09 10:17:58 UTC

Pushed both, but I put back the icon to htc-dream-adp1-g1-magic-tattoo.mpi.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.