Bug 30726 - Add 5 HTC Android phones
Summary: Add 5 HTC Android phones
Status: RESOLVED FIXED
Alias: None
Product: media-player-info
Classification: Unclassified
Component: New device (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Martin Pitt
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO
Depends on:
Blocks:
 
Reported: 2010-10-09 02:20 UTC by Jonathan Ernst
Modified: 2010-10-09 10:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch (795 bytes, patch)
2010-10-09 02:20 UTC, Jonathan Ernst 		Details | Splinter Review
new patch (930 bytes, patch)
2010-10-09 02:23 UTC, Jonathan Ernst 		Details | Splinter Review
Fix HTC Diamond file to not include other phones IDs (855 bytes, patch)
2010-10-09 09:41 UTC, Jonathan Ernst 		Details | Splinter Review
Fix HTC Diamond file to not include other phones IDs (863 bytes, patch)
2010-10-09 09:47 UTC, Jonathan Ernst 		Details | Splinter Review
Show Obsolete (2) View All

Description Jonathan Ernst 2010-10-09 02:20:04 UTC 
Created attachment 39299 [details] [review]
patch

HTC Dream
HTC Android Dev Phone 1
HTC G1
HTC Magic

(all have the same ids...)
Comment 1 Jonathan Ernst 2010-10-09 02:22:50 UTC 
Forgot the Tattoo too
Comment 2 Jonathan Ernst 2010-10-09 02:23:29 UTC 
Created attachment 39300 [details] [review]
new patch
Comment 3 Martin Pitt 2010-10-09 03:23:07 UTC 
These are already covered in media-players/htc-diamond.mpi. Perhaps we should just rename the file instead, or split it?
Comment 4 Jonathan Ernst 2010-10-09 09:40:38 UTC 
(In reply to comment #3)
> These are already covered in media-players/htc-diamond.mpi. Perhaps we should
> just rename the file instead, or split it?

I have made a new patch against htc-diamond.mpi so only its ID is in the file.

I guess you can then apply the previous patch and the one in Bug #30727 without USB ID conflicts.

Sorry for not checking this earlier and thanks for watching
Comment 5 Jonathan Ernst 2010-10-09 09:41:14 UTC 
Created attachment 39307 [details] [review]
Fix HTC Diamond file to not include other phones IDs
Comment 6 Jonathan Ernst 2010-10-09 09:47:05 UTC 
Created attachment 39308 [details] [review]
Fix HTC Diamond file to not include other phones IDs
Comment 7 Martin Pitt 2010-10-09 10:17:58 UTC 
Pushed both, but I put back the icon to htc-dream-adp1-g1-magic-tattoo.mpi.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.