| Summary: | McpAccountStorage::toggled is unimplemented | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Danielle Madeley <danielle> |
| Component: | mission-control | Assignee: | Danielle Madeley <danielle> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/danni/telepathy-mission-control.git;a=shortlog;h=refs/heads/implement-acct-toggled | ||
| Whiteboard: | review+ with minor changes | ||
| i915 platform: | i915 features: | ||
|
Description
Danielle Madeley
2010-05-27 20:13:42 UTC
This patch exposes an mcd_account_set_enabled that can be called by both the D-Bus property setter and by the McdAccountManager. Err, poop. I posted this to the wrong bug report. Swapping the titles :-P > +gboolean > +mcd_account_set_enabled (McdAccount *account, This should be _mcd_account_set_enabled in mcd-account-priv.h (-priv is the MC equivalent of -internal in telepathy-glib). Adding more API to libmissioncontrol-server is deprecated, while we try to get rid of it. > + mcd_account_set_enabled (account, on, FALSE, &error); > + if (error != NULL) Trivia: blank line before "if", please. (In reply to comment #4) > > +gboolean > > +mcd_account_set_enabled (McdAccount *account, > > This should be _mcd_account_set_enabled in mcd-account-priv.h (-priv is the MC > equivalent of -internal in telepathy-glib). Adding more API to > libmissioncontrol-server is deprecated, while we try to get rid of it. > > > + mcd_account_set_enabled (account, on, FALSE, &error); > > + if (error != NULL) > > Trivia: blank line before "if", please. Both of these are fixed and this is merged. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.