Bug 27299

The commit that introduced this problem was made to fix bug #17933
so there are some comments in that bug report that might be useful
here.

-Carl

From bug 17933 we not that [server-side] fallback paths are not directly involved here, so it is not clear what the cause is. What I would like is a minimum gtk+ app that can be run as the solitary client of an X server so that I can trace the entire system and see what code paths are actually involved...

(In reply to comment #0)
> Side note: is there a test suite I can run? I usually use latest git master
> daily but I guess I could give you a more "scientific" hand if I run test
> suites also.

We don't have anything specific for the driver, but we often use other
graphics-related test suites as standins, (for example cairo's test suite).

But note that historically, our driver hasn't been able to pass cairo's
test suite entirely. And fixing *that* was one of the motivating factors
that led Chris to implement the fix that caused this regression. ;-)

-Carl

Carl I'm using cairo 1.9.6, maybe that's relevant for this bug?

I'm seeing the bug on two i865 systems :
Card:Intel 810 and later: Intel Corporation|82865G Integrated Graphics
Controller [DISPLAY_VGA] (rev: 01)

and 

Card:Intel 810 and later: Intel Corporation|82865G Integrated Graphics
Controller [DISPLAY_VGA] (vendor:8086 device:2572 subv:1043 subd:80a5) (rev:
02)

with driver 2.11.0 with xorg server 1.7.6 on mandriva cooker.

It is with either cairo 1.9.6 or cairo 1.8.8 and either with pixman 0.18.0 or
0.16.2

A few recent patches pushed to master hook up the ShmPutImage to convert xrgb to argb.

In particular:

commit 2d17bd50af367bead84985c22fdd43d264a5f072
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Apr 14 14:54:34 2010 +0100

    Revert "Revert "uxa: Try using put_image when copying from a memory buffer.""
    
    This reverts commit 6d50553e8f70d8f2142efdfd6c90bc27a599d0bc.
    
    Now we have taught the fallback path not to infinitely recurse,
    re-enable the accelerated path for ShmPutImage and friends.

And the subsequent patches to handle the failed pixman_blt. Does this fix/explain the corruption?

for the record, 2.11.0 + patches 1cc2c2c44ac72460cf1c4e6bdc13c612235809c9 27195d7dba0f3ff08b92f3fd916cdf5113cbef58  9a5cd65b593ea82e56e0c403f7ddcc2420a64dc3 8562b7bc6740eef2602af76b8685388efd2d4d37

does not fix the problem.

Tested lasted git-version of the intel-driver (Up to commit 	0d4dd00aeafdd625ffe902e26e666b63a0842adc).

Problem is still present on my 855GM-based notebook.

Software :

Xserver from Ubuntu 10.04, latest git libdrm and intel-driver.

I believe this should be fixed now.

Hi Chris,

For me the bug is now fixed. No more false colors. I'm using the latest version (up to commit 58b089febceca1e915607bb723ee658aaa9dbed3) of the driver.

Thanks Stefan, I haven't had a chance to fire up my i845 to check.

Hi Chris,

this is also fixed for me on master, but now menu highlighting results in a blank (no text) line *only when approaching from the south of the screen*. 
Plus, test-tfp (your ad-hoc performance test on a recente bug) has degraded terribly for me.