Bug 27193

Summary:	dbus-glib-0.84 fails testsuite
Product:	dbus	Reporter:	Pacho Ramos <pachoramos1>
Component:	GLib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium	CC:	dirtyepic, freedesktop-bugs, rob.taylor
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/dbus-glib-smcv.git;a=shortlog;h=refs/heads/27193
See Also:	http://bugs.gentoo.org/show_bug.cgi?id=254192
Whiteboard:	r+ from walters
i915 platform:		i915 features:
Attachments:	build.log Run run-with-tmp-session-bus.sh directly rather than via ${SHELL}

Description Pacho Ramos 2010-03-19 04:40:24 UTC

Created attachment 34235 [details]
build.log

Similar to https://bugs.freedesktop.org/show_bug.cgi?id=19647

From our downstream bug report:
http://bugs.gentoo.org/show_bug.cgi?id=254192#c4

and reproduced myself with 0.84

Thanks a lot

Comment 1 Simon McVittie 2011-01-04 10:07:15 UTC

Patch in gitweb, I'll attach it in a moment.

Comment 2 Simon McVittie 2011-01-04 10:08:10 UTC

Created attachment 41633 [details] [review]
Run run-with-tmp-session-bus.sh directly rather than via ${SHELL}

It has a correct #!/bin/sh line and is executable, so just running it is
fine. This avoids running it under a user's chosen interactive shell,
which might be non-POSIX (zsh, csh). Gentoo Portage apparently sets
SHELL to /bin/false, presumably to trap this sort of thing.

Comment 3 Colin Walters 2011-01-06 14:20:33 UTC

Review of attachment 41633 [details] [review]:

Looks good, thanks!

Comment 4 Simon McVittie 2011-01-10 04:30:32 UTC

Thanks, fixed in git for 0.94.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.