| Summary: | [PATCH] xf86-input-elographics: Add support for GeneralTouch serial touchscreens | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Ivan Afonichev <ivan.afonichev> | ||||||
| Component: | Input/elographics | Assignee: | Xorg Project Team <xorg-team> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||
| Severity: | normal | ||||||||
| Priority: | medium | CC: | peter.hutterer | ||||||
| Version: | git | Keywords: | patch | ||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| i915 platform: | i915 features: | ||||||||
| Attachments: |
|
||||||||
|
Description
Ivan Afonichev
2009-10-19 07:58:54 UTC
Thanks for the patch and sorry about the delay. Things are rather busy here. I noticed that the gist of the patch is to avoid the error detection for the elographics hardware. While this may work for this particular touchscreen, we loose out if the screen is neither elographics nor a GeneralTouch. is there any way of detecting if the screen is a GeneralTouch screen? I think if screen is neither elographics nor a GeneralTouch we wouldn't guarantee user it's working. I'll test how Xorg with patched xf86-input-elographics is working with no touchscreen attached later on this week.(I think other pointing device such as mouse should work normally) I test it 2009-12-11. Everything is ok. USB and PS/2 mice are working good also when driver is loaded and touchscreen not attached. And there was no abnormal activity of X11 or something else. one change I'd like you to make in this patch please: instead of using comments to deactivate the code, just remove it. there's no reason to leave it there if we're not going to call it anyway. when you re-submit the patch please make sure you sign off the patch, I'll push it to once it's attached here. Thanks again for the patch. Created attachment 32140 [details] [review] Remove unnecessary comments patch to be pushed after previous patch Pushed as ac5366d6e1f26e6ceef3d062ab7df301d623cf54, thanks for the patch! i forgot to mention - i squashed the two patches into a single commit before pushing. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.