Bug 24007

Summary: Compile bug on X.Org X Server 1.6.99.1
Product: xorg Reporter: Bryan <duff0097>
Component: Driver/intelAssignee: Carl Worth <cworth>
Status: RESOLVED WONTFIX QA Contact: Xorg Project Team <xorg-team>
Severity: minor    
Priority: medium Keywords: NEEDINFO
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
use different image_from_pict function call none

Description Bryan 2009-09-17 20:44:04 UTC 
Created attachment 29651 [details] [review]
use different image_from_pict function call

Without the attached patch I get a "too many arguments" error from gcc for this Xorg function: image_from_pict.

The patch allows the xf86-video-intel driver to compile correctly.
Comment 1 Carl Worth 2009-10-26 11:22:02 UTC 
Hi Bryan,

Thanks for reporting this issue and providing the patch.

Unfortunately, I'm not sure what we should do here. The change in the X server
that triggered the breakage in the driver is the following commit:

    commit e9aa61e9f0d663d5b34a397b943b4d1df44e873d
    Author: Søren Sandmann Pedersen <sandmann@redhat.com>
    Date:   Sat Jun 13 10:28:21 2009 -0400

        Fix clipping when windows are used as sources
    
        The new clipping rules:
    
            - client clips happen after transformation
            - pixels unavailable due to the hierarchy are undefined
    
        The first one is implemented in pixman; the second one is realized by
        making a copy of window sources (to prevent out-of-bounds access).

Both before and after this commit, the X server advertised a version of
1.6.99.1.

So there are some X servers of version "1.6.99.1" that have the two-argument
image_from_pict and other X servers also of version "1.6.99.1" that have the
three-argument version. We just can't win when interfaces change without
corresponding changes to version numbers.

Were you building from an X server git checkout? These days an X server
git checkout gives a version number of 1.7.99.1 so it should work just fine.

Or were you perhaps building from some tar file release of "1.6.99.1"?
If there's something out there like that, then we probably should change
the driver to work with it.

Let me know,

-Carl
Comment 2 Eric Anholt 2009-12-03 10:50:19 UTC 
no 1.6.99.1 tarball was published, so I think we can go ahead and WONTFIX this one.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.